-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two tweaks to make this compatible with 1.29 #4
base: master
Are you sure you want to change the base?
Conversation
…user click a button to confirm a purge, and users won't like that
Also! I ended up pulling in I'll put that in as a comment at least~ |
@jpgill86 could you also enable Issues maybe? (at https://github.com/CWRUChielLab/CASAuth/settings ) |
Hello @caseywatts, Since we use this repository for our internal systems, I will need to verify that these changes don't break anything in our environment before merging your pull request. I don't expect that I will have time to check this soon--hopefully in August! Jeff |
I can confirm, this pull request works for me with MediaWiki 1.35 LTS. It should be fixed like this:
Problem: there is no getName in https://github.com/wikimedia/mediawiki/blob/master/includes/session/Session.php#L48 it works for me with
But that does not work with a new logout ticket session, I don't know what single signing-out means and is. And I need to reload the page, otherwise I still get the error described in #13. |
(descriptive commits :) )