Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two tweaks to make this compatible with 1.29 #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

caseywatts
Copy link

@caseywatts caseywatts commented Jun 13, 2017

(descriptive commits :) )

@caseywatts
Copy link
Author

Also! I ended up pulling in jasig/phpCAS via composer so I had to tweak this line:
$CASAuth["phpCAS"]="$IP/vendor/jasig/phpcas";

I'll put that in as a comment at least~

@caseywatts
Copy link
Author

@jpgill86 could you also enable Issues maybe? (at https://github.com/CWRUChielLab/CASAuth/settings )
I wanted to start a thread about making this a composer package :)

@jpgill86
Copy link
Member

Hello @caseywatts,

Since we use this repository for our internal systems, I will need to verify that these changes don't break anything in our environment before merging your pull request. I don't expect that I will have time to check this soon--hopefully in August!

Jeff

@tpokorra
Copy link

tpokorra commented Apr 10, 2021

I can confirm, this pull request works for me with MediaWiki 1.35 LTS.
I must correct myself, the logout does not work, as described in #13.

It should be fixed like this:

// Store the session name and id in a new logout ticket session to be able
// to find it again when single signing-out
function casPostAuth($ticket2logout) {

        // remember the current session name and id
        $session = MediaWiki\Session\SessionManager::getGlobalSession();
        // $old_session_name=$session->getName();
        $old_session_id=$session->getId();

Problem: there is no getName in https://github.com/wikimedia/mediawiki/blob/master/includes/session/Session.php#L48

it works for me with

        $session = MediaWiki\Session\SessionManager::getGlobalSession();
        $session->clear();
        return;

But that does not work with a new logout ticket session, I don't know what single signing-out means and is.

And I need to reload the page, otherwise I still get the error described in #13.

@tpokorra tpokorra mentioned this pull request Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants